mysql-client: fix add authentication plugins in [email protected] #181805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
autosquash
cswingler
force-pushed
the
mysql-client-90-auth-plugin
branch
from
297f0cb
to
ba8b9c8
Compare
This adds the `-DWITH_AUTHENTICATION_CLIENT_PLUGINS=yes` flag to add support for older MySQL authentication methods. This support was in the default build prior to MySQL 9.0, but were dropped with that release. Closes Homebrew#180498
cswingler
force-pushed
the
mysql-client-90-auth-plugin
branch
from
ba8b9c8
to
0dc3ffd
Compare
github-actions
bot
removed
the
autosquash
|
Can you make an issue upstream requesting they enable this by default and add that as a comment? From the linked thread it seems like upstream thinks it's default already. |
cho-m
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?This addresses #180498 .
The MySQL 9.0 client is not built with support for older authentication methods by default, which breaks the ability for the MySQL client, and packages that depend on it, to connect to servers still using authentication methods like
mysql_native_password. This adjusts the build process to add those back in as plugins.