fix: ML backend logger in docker doesn't show errors #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #628 +/- ##
==========================================
- Coverage 55.71% 51.19% -4.52%
==========================================
Files 54 43 -11
Lines 3660 2967 -693
==========================================
- Hits 2039 1519 -520
+ Misses 1621 1448 -173 ☔ View full report in Codecov by Sentry. |
micaelakaplan
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logging configuration is overriding Gunicorn's own logging setup. Without proper handling, this can suppress Gunicorn's error messages, including critical ones like ModuleNotFoundError.
"disable_existing_loggers": False: This prevents your logging configuration from disabling loggers that have already been defined by other modules, such as Gunicorn.