feat: Make tokenizer add_special_tokens option configurable
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhill
force-pushed
the
omit_special_tokens
branch
from
7c1ff02
to
2afbf1c
Compare
In particular so that it can be disabled for chat/instruct models where an explicit template is used that already includes these tokens. (for example the leading <s> token added by llama and mixtral tokenizers) Signed-off-by: Nick Hill <[email protected]>
njhill
force-pushed
the
omit_special_tokens
branch
from
2afbf1c
to
7f074ac
Compare
Xaenalt
pushed a commit
to Xaenalt/text-generation-inference
that referenced
this pull request
Aug 14, 2024
RHOAI 2.8.4 granite attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular so that it can be disabled for chat/instruct models where an explicit template is used that already includes these tokens. For example the leading
<s>token added by llama and mixtral tokenizers.This allows it to be configured globally. We could potentially support per-request in future.