can't put code outside of wrapper with new build system

[Aradiv]

i need to place some code outside of wrapper() since i have various things running in GM sandbox that don't want to expose.

Functions that need to be accessible are placed inside wrapper everything else is outside wrapper

with the old build system i just placed the code before the @@PLUGINSTART@@ and could control where my code is running.

[johnd0e]

@Aradiv old system was not possible to use for own plugins at all

[Aradiv]

@johnd0e i used the old system for own plugins all the time

[johnd0e]

Ok, but I need sample of such code.

[Aradiv]

example script that will alert "newToken" every second refresh

redacted.user.js.txt

[johnd0e]

redacted.user.js.txt

Still, I do not see here secure way to operate data.
Yes,, you avoid saving it to localStorage. But now you have to expose some unsecure function to retrieve that data.

[Aradiv]

redacted.user.js.txt

Still, I do not see here secure way to operate data.
Yes,, you avoid saving it to localStorage. But now you have to expose some unsecure function to retrieve that data.

the token never needs to be retrieved outside the sandbox since all querys with the token are made inside of it. So unless you expose the getToken() function you can't retrieve the token outside of the plugin sandbox.

• you cant call getToken
• if you overwrite awesomeFunction you can't retrieve the token anymore

[johnd0e]

Let's begin from start: how do you put value into sandbox initially?
Is it just hardcoded like in redacted.user.js?

Then it is not more secure than if you just hardcodes it in some local variable.

[Aradiv]

you could just window.prompt it

[johnd0e]

@Aradiv OK, that makes sense.

But still most applications I can ever imagine would require data exposition, in one or another way.
E.g. earlier you suggested usage for tile layers apikeys.
But after you initialize L.TileLayer - everyone can see it's properties, even private ones.

Well, you can implement own leaflet class, that will keep apikey hidden. But again, in some point you should use it in web request, which can hijacked by anyone (on your machine).

Because of such their nature api keys are designed not to keep top-secret data.

[Aradiv]

a lot of the map providers provide the ability to create short lived read only limited access tokens when you have a long live one. so exposing the short lived one is okay (sometimes you can even ip bind it) but you should never expose the long lived ones.

[Aradiv]

and if you do your requests from inside the sandbox it is still not visible to any other plugin

[johnd0e]

@Aradiv Really? I would like to see real samples if you have them (or when you will have, in the future).

In general, I agree that there can be some limited application for GM sandbox. But it's not for wide use.

You see my related PR, do if you want — feel free to test it, fix it, and improve it.

[Aradiv]

yes this is only usefull for things that interact with third party services and maybe some operation critic information that you want to have specially protected.

[johnd0e]

This discussion made me think that may be we can greatly simplify our wrapper code.
Following sample does not use script injection (continued in #358):

// ==UserScript==
// @name            IITC plugin: [redacted] tiles
// @version         0.2.1
// @namespace       redacted
// @match           https://intel.ingress.com/*
// @grant           GM.getValue
// @grant           GM.setValue
// @grant           GM.deleteValue
// ==/UserScript==

window = typeof unsafeWindow !== 'undefined' ? unsafeWindow : window;
// ensure plugin framework is there, even if iitc is not yet loaded
if(typeof window.plugin !== 'function') window.plugin = function() {};

const key = 'plugin-[redacted]-token';
function Token (action, token) {
    return GM[action + 'Value'](key, token);
}
function setup () {
    Token('get').then(token => {
        if(token === undefined){
            Token('set', "newToken");
        } else {
            Token('delete');
            alert(token);
      }
    });
};

var info = {};
if (typeof GM_info !== 'undefined' && GM_info && GM_info.script) info.script = { version: GM_info.script.version, name: GM_info.script.name, description: GM_info.script.description };
var plugin_info = info;

setup.info = plugin_info; //add the script info data to the function as a property
if(!window.bootPlugins) window.bootPlugins = [];
window.bootPlugins.push(setup);
// if IITC has already booted, immediately run the 'setup' function
if(window.iitcLoaded && typeof setup === 'function') setup();

Update: this code does not actually work for GM

[Aradiv]

@johnd0e IMHO The window = unsafeWindow
is not really a good idea
Since you can't put code only in sandbox anymore.

Put except this it looks okay

[johnd0e]

Since you can't put code only in sandbox anymore.

Right. But we can fix that with #356