Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build_plugin.py: some code can be placed outside of wrapper #356

Merged
merged 1 commit into from
Apr 24, 2020
Merged

build_plugin.py: some code can be placed outside of wrapper #356

merged 1 commit into from
Apr 24, 2020

Conversation

johnd0e
Copy link
Contributor

@johnd0e johnd0e commented Mar 5, 2020 •
edited
Loading

Close #354

To leave some code out of wrapper use special marker (on separate line):

'this_is_unwrapped';
/*wrapped-from-here*/

@johnd0e johnd0e added the development general development issue label Mar 5, 2020
build_plugin.py: some code can be placed outside of wrapper
ae5b9f1 
This may be needed to use GM_* functions
- https://wiki.greasespot.net/Greasemonkey_Manual:API
- https://www.tampermonkey.net/documentation.php

To leave some code out of wrapper use special marker (on separate line):

/*wrapped-from-here*/
@johnd0e johnd0e requested a review from modos189 March 6, 2020 14:41
@johnd0e johnd0e marked this pull request as ready for review March 6, 2020 14:41
@johnd0e
Copy link
Contributor Author

johnd0e commented Mar 6, 2020

@Aradiv

Please check if it works as expected by you.

@johnd0e johnd0e mentioned this pull request Mar 7, 2020
Draft
10 tasks
@johnd0e
Copy link
Contributor Author

johnd0e commented Mar 7, 2020

It seems that #358 has better solution

@johnd0e johnd0e mentioned this pull request Mar 7, 2020
Closed
modos189
modos189 approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@modos189 modos189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks bad, but as a temporary solution is acceptable. Especially, as I understand it, after #358 there will simply be no need to comment /wrapped-from-here/ - it will work without this comment.

@johnd0e
Copy link
Contributor Author

johnd0e commented Apr 24, 2020

No, #358 was initially based on wrong assumption.
It cannot be used in GreaseMonkey and IITC-Button.

@johnd0e johnd0e merged commit 4398a66 into IITC-CE:master Apr 24, 2020
@johnd0e johnd0e deleted the code-before-wrapper branch April 24, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modos189 modos189 modos189 approved these changes

Assignees
No one assigned
Labels
development general development issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can't put code outside of wrapper with new build system
2 participants
@johnd0e @modos189