Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNIQUES - Adding support for scouted and droned portals #378

Closed
wants to merge 4 commits into from
Closed

UNIQUES - Adding support for scouted and droned portals #378

wants to merge 4 commits into from

Conversation

MysticJay
Copy link
Contributor

@MysticJay MysticJay commented Jul 21, 2020 •
edited
Loading

  • Two new checkboxes allow to indicate if a portal was scouted or if has been visited by the players drone.
  • Portal-list allows to sort on either of these.
  • Intel-Comm is analyzed to automatically identify portals for UPV, UPC and Scout.
  • new highlighters for "Scouted" and "Droned"
  • replaced the columns titels:
    V - UPV (Unique Portals Visited)
    C - UPC (Unique Portals Captured)
    S - User is scout for this portal
    D - User visited this portal with his drone (no related COMM messages available, thus only manual)

Please be aware that Comm detection/analysis is not reliable due to not all data delivered from intel servers.

@MysticJay
Copy link
Contributor Author

MysticJay commented Jul 21, 2020 •
edited
Loading

need to add detection for scout on:

You were displaced as Scout Controller on Harald Hardrådes plass. Retake your position.

Agent DhrMekmek will verify this to work:

} else if(plext.plextType == 'SYSTEM_NARROWCAST' && markup.length==3 && markup[0][0] == 'TEXT' && markup[0][1].plain == 'You were displaced as Scout Controller on' && markup[1][0] == 'PORTAL') { // search for "You were displaced as Scout Controller on" var portal = markup[1][1]; var guid = window.findPortalGuidByPositionE6(portal.latE6, portal.lngE6); if(guid) plugin.uniques.setPortalScouted(guid); }

@MysticJay
Highlighters
23037ab 
Added Highlighters
description
added new text to comm analysis
minor cosmetics
MysticJay
MysticJay commented Jul 27, 2020
View reviewed changes
Copy link
Contributor Author

@MysticJay MysticJay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well tested by community.
RTM!

@MysticJay MysticJay marked this pull request as ready for review July 27, 2020 06:42
@MysticJay MysticJay changed the title Adding support for scouted and droned portals UNIQUES - Adding support for scouted and droned portals Jul 27, 2020
@MysticJay
sorting portalslist fixed
12ae44b 
sorting scouted or droned caused an empty list, as old uniques might not have the related fields.
@MysticJay
sorting uniques fixed
7c8da52 
Some combinations should not happen, but they do.
fixed too.
@MysticJay MysticJay mentioned this pull request Aug 6, 2020
Closed
@modos189 modos189 force-pushed the master branch 3 times, most recently from a34b800 to 7b9edd5 Compare December 12, 2020 07:21
@MysticJay
Copy link
Contributor Author

MysticJay commented Dec 18, 2020 •
edited by johnd0e
Loading

PR included in upcoming UNIQUES040
#416

@MysticJay MysticJay closed this Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MysticJay