Machina marker icon #659
Open
Machina marker icon #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new images in pNG, 2xPNG and SVG
🤖 Pull request artifacts
|
xscreach
reviewed
Aug 3, 2023
|
Is the PNG file still used somewhere? |
xscreach
approved these changes
Jan 22, 2024
xscreach
suggested changes
Jan 22, 2024
xscreach
reviewed
Jan 22, 2024
xscreach
reviewed
Jan 22, 2024
Fix for mobile
xscreach
suggested changes
Feb 8, 2024
| iconUrl: iconImage, | ||
| iconRetinaUrl: iconImage, | ||
| iconSize: [26, 32], | ||
| iconAnchor: [12, 32], |
There was a problem hiding this comment.
Any comment on why you want to specify different sizes than defaults here?
It makes the icon smaller than the Enl/Res tracker.
And the values are now same as default, then remove them and keep the default in use - there's no need to specify it again and will result in more work later when we'll want to change the size of all these tracker markers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new images in pNG, 2xPNG and SVG