Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

250 indp notebook #257

Merged
merged 14 commits into from
Aug 15, 2023
Merged

250 indp notebook #257

merged 14 commits into from
Aug 15, 2023

Conversation

longshuicy
Copy link
Member

@longshuicy longshuicy commented Aug 9, 2023

Note: There is an endpoint implemented in dev but not prod yet. This will cause the building damage to fail. To continue testing INDP, a workaround cell is added (BUT before merging into develop this cell needs to go away). To test, skip the building damage cell for now and run the temporary cell instead

image

@longshuicy longshuicy linked an issue Aug 9, 2023 that may be closed by this pull request
@ylyangtw
Copy link
Contributor

I tested it locally but I am not sure why it is accessing the prod... And the feature is not in prod yet, so the notebook stops.
image

@ywkim312
Copy link
Member

I tested it locally but I am not sure why it is accessing the prod... And the feature is not in prod yet, so the notebook stops. image

if you want to point incore-dev please change your client like this
client = IncoreClient("https://incore-dev.ncsa.illinois.edu")

@ylyangtw
Copy link
Contributor

just tried incore-dev but some dataset seems not in dev
image

@ywkim312
Copy link
Member

just tried incore-dev but some dataset seems not in dev image

Yes you're right. Dev lacks some dataset. I am running on prod now and will update how it goes

@ylyangtw
Copy link
Contributor

ylyangtw commented Aug 14, 2023

Notebook works!
image

Copy link
Contributor

@ylyangtw ylyangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good~ Approve

notebooks/indp.ipynb Outdated Show resolved Hide resolved
notebooks/indp.ipynb Outdated Show resolved Hide resolved
@ywkim312 ywkim312 merged commit dce1a3b into develop Aug 15, 2023
1 check passed
@ywkim312 ywkim312 deleted the 250-indp-notebook branch August 15, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INDP notebook
4 participants