Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

303 add asce 2023 inspire workshop material #304

Merged
merged 15 commits into from
Dec 7, 2023

Conversation

ylyangtw
Copy link
Contributor

No description provided.

@ylyangtw ylyangtw linked an issue Nov 21, 2023 that may be closed by this pull request
@ylyangtw ylyangtw self-assigned this Nov 22, 2023
@longshuicy
Copy link
Member

Could you add this workshop structure to the table of content on the sidebar by adding to here: https://github.com/IN-CORE/incore-docs/blob/main/manual_jb/content/_toc.yml#L74
Thanks!

Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also could you help me verify the if the fragility tables looks correct in session 4? Somehow when i open it in github webpage, it's not rendering correctly. Thanks!

@navarroc
Copy link
Member

navarroc commented Dec 1, 2023

Session 4 is missing from the side bar and the answers for Session 2 Assignment has the same name in the side bar as the assignment so it looks like an error. It should be:
Session 2 Assignment
Session 2 Answers

Or Session 2 Assignment Answers

… title so the toc distinguished between the assignment and answers
@navarroc
Copy link
Member

navarroc commented Dec 4, 2023

@longshuicy Can you take a look at my changes? Since Ya-Lan is out this week, I fixed two TOC issues. First, session 4 wasn't being displayed and since the answer notebook had the same title as the assignment, even though the TOC linked to the correct notebook, the display name came from the notebook internal title so it showed as:

Session 2 Assignment
Session 2 Assignment

@longshuicy
Copy link
Member

@longshuicy Can you take a look at my changes? Since Ya-Lan is out this week, I fixed two TOC issues. First, session 4 wasn't being displayed and since the answer notebook had the same title as the assignment, even though the TOC linked to the correct notebook, the display name came from the notebook internal title so it showed as:

Session 2 Assignment Session 2 Assignment

Looks good to me!

@ywkim312
Copy link
Member

ywkim312 commented Dec 5, 2023

The section 5 of session should have the screen shot

@ywkim312
Copy link
Member

ywkim312 commented Dec 5, 2023

The session 2's agenda internal link doesn't work since it is designed to work in the notebook. It will work in the actual notebook but not in the documentation web page

@longshuicy longshuicy merged commit 57a4623 into develop Dec 7, 2023
1 check passed
@navarroc navarroc deleted the 303-add-asce-2023-inspire-workshop-material branch December 20, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ASCE 2023 INSPIRE workshop material
4 participants