Fix to the warning, using string sum instead #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vismayak
changed the title
longshuicy
requested changes
Jan 17, 2024
Vismayak
force-pushed
the
312-joplin-testbed-pandas-sum-function-warning
branch
from
6c3b2a9
to
7157a99
Compare
Vismayak
force-pushed
the
312-joplin-testbed-pandas-sum-function-warning
branch
from
8c144d6
to
b401b43
Compare
longshuicy
requested changes
Feb 2, 2024
There was a problem hiding this comment.
- Could you fix the conflict
- Code works well. But when I unzip I noticed there are additional macos files
- In the zip file; the notebook shouldn't contain any output cells. The output cell is only for notebooks under content/notebooks (for displaying on the documentation site)
|
Checked the output against the previous and everything looks good. If you can address the issues @longshuicy identified, then I think it'll be ready to merge. |
|
@navarroc @longshuicy I think it is ready now to be merged :) |
|
Can you remove the .ipynb_checkpoints folder from each zip file? |
|
@navarroc removed 👍 |
|
Sorry to nitpick, but can you remove the hidden .DS_Store file in the Galveston zip file? Thank you! |
|
Can you remove the __MACOSX folder in the zips? |
Rashmil-1999
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.