Fixed the url for INSPIRE workshop zip file #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah actually can you change the other way around? then you don't need to rename the zip :-) |
ywkim312
approved these changes
Jan 17, 2024
Yeah I thought about that too. But I changed my mind because some notebooks are using workshop_2023-11-15.zip, also workshops 20210526 and 20220131 are using workshop_xxxx-xx-xx.zip as naming. |
Make sense. I'll approve. |
longshuicy
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After release, this url for inspire workshop zip file should be available: https://github.com/IN-CORE/incore-docs/blob/main/workshops/20231115/workshop_2023-11-15.zip
No test is needed. Please check the changes are ok.