Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

339 Add galveston community app notebook with retrofit #357

Merged
merged 11 commits into from
Apr 10, 2024

Conversation

Vismayak
Copy link
Member

No description provided.

@Vismayak Vismayak linked an issue Mar 20, 2024 that may be closed by this pull request
11 tasks
@Vismayak Vismayak self-assigned this Mar 20, 2024
@Vismayak Vismayak marked this pull request as draft March 20, 2024 19:48
@longshuicy longshuicy marked this pull request as ready for review March 26, 2024 18:39
@longshuicy longshuicy changed the title 339 Add galveston community app notebook with retrofit [WIP] 339 Add galveston community app notebook with retrofit Mar 26, 2024
@navarroc navarroc requested a review from ywkim312 April 2, 2024 18:28
@ywkim312
Copy link
Member

ywkim312 commented Apr 2, 2024

Can you update changelog?

@ywkim312
Copy link
Member

ywkim312 commented Apr 2, 2024

please fix the conflict

@ywkim312
Copy link
Member

ywkim312 commented Apr 2, 2024

I got this error in Surge-Wave building damage for Galveston

ERROR - http_util.py:return_http_response() - A HTTPError has occurred 
HTTP Status code: 404
Error Message: Could not find the dataset 65dcf904c013b927b93bf632```

@ywkim312
Copy link
Member

ywkim312 commented Apr 3, 2024

I got an error from following cell

ret_json = DataProcessUtil.create_mapped_dmg_result_gal(
    bldg_gdf, combined_dmg_retrofit_df_rs, arch_mapping, "max_state", "arch_wind"
)
ret_json

the error is

AttributeError                            Traceback (most recent call last)
Cell In[14], line 1
----> 1 ret_json = DataProcessUtil.create_mapped_dmg_result_gal(
      2     bldg_gdf, combined_dmg_retrofit_df_rs, arch_mapping, "max_state", "arch_wind"
      3 )
      4 ret_json

AttributeError: type object 'DataProcessUtil' has no attribute 'create_mapped_dmg_result_gal'

Copy link
Member

@ywkim312 ywkim312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notebook ran successfully in incore-lab

Copy link
Member

@navarroc navarroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This notebook should be linked in the manual in manual_jb/content/notebooks_other.md. I would put them under the analyses section.

@ywkim312 ywkim312 merged commit 1a4fa54 into develop Apr 10, 2024
1 check passed
@ywkim312 ywkim312 deleted the 339-update-galveston-community-app-notebook branch April 10, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Galveston Community app notebook
3 participants