Update defaults.py #539
Merged
Update defaults.py #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proccaserra
approved these changes
Feb 25, 2024
terazus
reviewed
Mar 1, 2024
| @@ -17,14 +17,14 @@ def test_b_ii_s_3(self): | |||
| data_path = path.join(path.dirname(path.abspath(__file__)), '..', '..', 'data', 'tab', 'BII-S-3') | |||
| with open(path.join(data_path, 'i_gilbert.txt'), 'r') as data_file: | |||
| r = validate(fp=data_file, config_dir=self.default_conf, origin="") | |||
| self.assertEqual(len(r['warnings']), 12) | |||
| self.assertEqual(len(r['warnings']), 10) | |||
There was a problem hiding this comment.
Two DOIs were actually valid, this is why there's only 10 warnings left instead of 12
The previous regex didn't match any DOI I tried. I found this one in a blog post from Crossref where they say it matched 74.4M out of 74.9M DOIs that they have seen. The post is here: https://www.crossref.org/blog/dois-and-matching-regular-expressions/
Since the DOI regex works now there are 2 fewer warnings. Previously it was warning about valid DOIs.
|
I rebased to issue-511. It has the same changes that are on #549, so if that is merged first there should only be the changes to the DOI regex and 1 test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous regex didn't match any DOI I tried. I found this one in a blog post from Crossref where they say it matched 74.4M out of 74.9M DOIs that they have seen. The post is here: https://www.crossref.org/blog/dois-and-matching-regular-expressions/