Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial i18n support for notification #1773

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Boteium
Copy link

@Boteium Boteium commented Jun 18, 2023

I decide to write a PoC for notification i18n support #1473
This requires InfiniTimeOrg/lvgl#3

This will enable people to start working on i18n support for their own languages.
The design uses external flash so that people can flash the language pack of their choice.
To reduce memory footprint, only the very basic glyph should be added, which means the example provided here (latin.json) should further be split to Spanish, French, Sweden ... etc

We should also limit the file size of this font to prevent people from building a huge font that will crash and brick their watches. So, It is not possible to add support for Chinese or Japanese using this method.

InfiniSim_2023-06-18_180701

.

@Boteium Boteium marked this pull request as draft June 18, 2023 10:08
@github-actions
Copy link

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed

@FintasticMan FintasticMan added the enhancement Enhancement to an existing app/feature label Jul 13, 2023
@everypizza1
Copy link
Contributor

Can we also have this on the music screen? A lot of my playlists are Japanese music.

@Boteium
Copy link
Author

Boteium commented Aug 12, 2023

Can we also have this on the music screen? A lot of my playlists are Japanese music.

Well, It depends,

Yes, we can make this method system wide.
But no, Japanese contains too many glyphs, which won't fit in the memory.

However, limited support is possible. (e.g. only includes hiragana and katakana)

@everypizza1
Copy link
Contributor

everypizza1 commented Aug 12, 2023 via email

@FintasticMan
Copy link
Member

We can't romanize it on-device, that would require a lot of logic we don't want to implement, but the companion app would be able to.

@ThatOneCalculator
Copy link

I think hiragana and katakana support would be better than nothing

@minimaxwell
Copy link

I've been testing this for a while, this looks like a good step towards proper i18n support. I've been using the latin pack, without it, notifications in french are barely readable. Thanks for that PR, hopefully this can be merge at some point :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing app/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants