Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: permissive cosine computation from non-orthogonal sform had reve… #4847

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

BUG: permissive cosine computation from non-orthogonal sform had reve… #4847

wants to merge 3 commits into from

Conversation

cookpa
Copy link
Contributor

@cookpa cookpa commented Sep 12, 2024 •
edited
Loading

…rsed SVD components

U and V were reversed in the reconstruction of M, according to definitions here

https://vxl.github.io/doc/release/core/vnl/html/classvnl__svd.html

As discussed in #4839

cc: @vfonov @hjmjohnson

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@github-actions github-actions bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances area:IO Issues affecting the IO module labels Sep 12, 2024
@cookpa
Copy link
Contributor Author

cookpa commented Sep 12, 2024

I will see if I can modify the existing tests to catch this

@cookpa
BUG: NIFTI "permissive" direction cosine error
c42f500 
Computation from non-orthogonal sform had reversed SVD components

U and V were reversed in the reconstruction of M, according to definitions here

https://vxl.github.io/doc/release/core/vnl/html/classvnl__svd.html
@vfonov
Copy link
Contributor

vfonov commented Sep 13, 2024

oops, looks like my typo

@cookpa
ENH: Test non-orthogonal NIFTI sform
a20a84f 
Catches direction flip introduced by earlier SVD bug
@github-actions github-actions bot added the type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct label Sep 13, 2024
@cookpa cookpa marked this pull request as ready for review September 13, 2024 17:25
jhlegarreta
jhlegarreta reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @cookpa 💯.

An inline comment.

Modules/IO/NIFTI/test/itkNiftiReadWriteDirectionTest.cxx Outdated Show resolved Hide resolved
@github-actions github-actions bot added the type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots label Sep 16, 2024
@jhlegarreta
Copy link
Member

/azp run ITK.macOS.Python

@thewtex thewtex requested a review from vfonov September 16, 2024 21:07
dzenanz
dzenanz reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz left review comments

@jhlegarreta jhlegarreta jhlegarreta left review comments

@hjmjohnson hjmjohnson Awaiting requested review from hjmjohnson

@vfonov vfonov Awaiting requested review from vfonov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:IO Issues affecting the IO module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cookpa @vfonov @jhlegarreta @dzenanz