Make the index type of VectorContainer itk::SizeValueType by default
#4856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, assume `ElementIdentifier = SizeValueType`, for an
`itk::VectorContainer<ElementType>`.
Conceptually like:
template <typename TElementIdentifier = SizeValueType, typename TElement>
class VectorContainer;
The index type (`ElementIdentifier`) of `itk::VectorContainer` is already `itk::SizeValueType` by default.
The index type (`ElementIdentifier`) of `itk::VectorContainer` is already `itk::SizeValueType` by default, and `itk::IdentifierType` is just an alias of `itk::SizeValueType`.
github-actions
bot
added
type:Testing
dzenanz
reviewed
Sep 20, 2024
| itkLegacyMacro(ArrayType GetRadius() const) { return this->GetRadiusInObjectSpace(); } | ||
|
|
||
| itkLegacyMacro(void SetRadiiInObjectSpace(ArrayType radii)) { this->SetRadiusInObjectSpace(radii); } | ||
| itkLegacyMacro(void SetRadius(double radius)) |
There was a problem hiding this comment.
This set of changes seems unrelated.
There was a problem hiding this comment.
Thanks! Honestly I have no idea why clang-format decided to make those unrelated changes 🤷
| @@ -96,7 +96,10 @@ class ITK_TEMPLATE_EXPORT MeshSpatialObject : public SpatialObject<TMesh::PointD | |||
|
|
|||
| #if !defined(ITK_LEGACY_REMOVE) | |||
| /** \deprecated Return the type of pixel used */ | |||
| itkLegacyMacro(const char * GetPixelTypeName()) { return m_PixelType.c_str(); } | |||
| itkLegacyMacro(const char * GetPixelTypeName()) | |||
There was a problem hiding this comment.
Unrelated. Preferably group with the other into a separate commit.
| @@ -85,7 +85,10 @@ class ITK_TEMPLATE_EXPORT TubeSpatialObject : public PointBasedSpatialObject<TDi | |||
|
|
|||
| #if !defined(ITK_LEGACY_REMOVE) | |||
| /** Compute the tangents and normals of the centerline of the tube. */ | |||
| itkLegacyMacro(bool ComputeTangentAndNormals()) { return ComputeTangentsAndNormals(); } | |||
| itkLegacyMacro(bool ComputeTangentAndNormals()) | |||
N-Dekker
commented
Sep 20, 2024
Comment on lines
-47
to
+54
| template <typename TElementIdentifier, typename TElement> | ||
| template <typename T1, typename T2 = void> | ||
| class ITK_TEMPLATE_EXPORT VectorContainer | ||
| : public Object | ||
| , private std::vector<TElement> | ||
| , private std::vector<std::conditional_t<std::is_void_v<T2>, T1, T2>> |
There was a problem hiding this comment.
Unfortunately this "trick" does not work as smoothly as I was hoping for.... The compiler still considers VectorContainer<ElementType> and VectorContainer<SizeValueType, ElementType> to be different types. Which disallows interchanging one with the other. (For example, assigning a pointer to another.) Not really convenient 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most use cases, it appears that the index type of
itk::VectorContainershould just beitk::SizeValueType(oritk::IdentifierType, but that's just an alias ofitk::SizeValueType).This pull request allows users to write
itk::VectorContainer<ElementType>as a shorthand foritk::VectorContainer<itk::SizeValueType, ElementType>.