Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Windows documentation #12013

Merged
merged 7 commits into from
Sep 10, 2023
Merged

Refactor Windows documentation #12013

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b87bea6
Small changes
Tamir91 Jul 18, 2023
3e67c2b
Note added
Tamir91 Jul 25, 2023
1923071
Note refactored
Tamir91 Jul 25, 2023
32f5255
small updates
Tamir91 Jul 31, 2023
7c5e356
CMake and Visual Studio versions updated
Tamir91 Aug 9, 2023
3b3f24f
typo fixed
Tamir91 Aug 30, 2023
dce9942
MSVC2015 updated
Tamir91 Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified doc/img/windows_cmake.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 6 additions & 9 deletions doc/installation_windows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,13 @@
# Windows 8.1 & Windows 10 Installation
# Windows 10 & Windows 11 Installation

**Note:** Due to the USB 3.0 translation layer between native hardware and virtual machine, the librealsense team does not recommend or support installation in a VM.

librealsense shall be built on Windows using [CMake v3.8+](https://cmake.org/download/) and Visual Studio 2015 / 2017:
librealsense shall be built on Windows using [CMake v3.8+](https://cmake.org/download/) and Visual Studio 2015 / 2017 / 2019 / 2022:
(MSVC2013 and older are not fully compatible with the C++11 feature-set).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove 2015

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we know Cmake 3.8 is not supported, we need to make sure which one is supported and list it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we know Cmake 3.8 is not supported, we need to make sure which one is supported and list it

According the test that we performed CMake 3.14 is minimal supported version.
Are you think we need perform other test to validate it? Maybe, install CMake 3.13 locally and build?

<a name="cmake_snapshot_win">
maloel marked this conversation as resolved.
Show resolved Hide resolved
![Windows CMake](./img/windows_cmake.png)
</a>
![link text][Win_cmake_image]

Don't forget to check `BUILD_EXAMPLES` if you wish to use librealsense samples.
![Windows CMake](./img/windows_cmake.png)

## Windows 8.1:
When working on Windows 8.1, make sure you have [KB3075872](https://support.microsoft.com/en-us/kb/3075872) and [KB2919355](https://support.microsoft.com/en-us/kb/2919355) installed. These patches are addressing issues specific to 8.1 video drivers, that were later resolved in Windows 10.
Don't forget to check `BUILD_EXAMPLES` if you wish to use librealsense samples.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Down in the document please update according to this:
Windows 10 (Build 15063 or later, 17763+ recommended) and Windows 11
The winver image needs to change too

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows 10 SDK version 1809 | 10.0.17763.0 is being validated by RS.
Lets write only this
Windows 10 (Build 15063 or later, 17763+ recommended) and Windows 11

Instead of both and give this screenshot
image

Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A build number and screenshot updated.

## Enabling metadata on Windows
Metadata attributes is an advanced capability provided by librealsense.
Expand Down Expand Up @@ -92,3 +87,5 @@ When set, the compiler will check the target WinSDK version, and abort the build

**Note** In case of multiple WinSDK version installed, CMake automatically selects the latest version of SDK. In some cases, however, the automatic selection may fail. Then you need to manually retarget the solution for the proper WinSDK version:
![win_retarget_platform](./img/win_retarget_platform.png)

**Note** Turn on "Allow desktop apps to access your camera" in Windows OS (Setting -> Privacy -> Camera).
Loading