Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Coin as the user-facing name of functions #614

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Aug 12, 2024

Changelog

- description: |
    Add `Lovelace` as a type synonym to `Coin`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

  1. Only adds a type synonym
  2. Removes a private function
  3. New type synonym is correctly exported

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc
Copy link
Contributor Author

smelc commented Aug 12, 2024

Thanks @carbolymer for the swift review!

cc @Jimbo4350

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Why not change Coin to Lovelace?

@smelc smelc enabled auto-merge August 13, 2024 09:55
@smelc smelc added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit b6ad2c1 Aug 13, 2024
26 of 27 checks passed
@smelc smelc deleted the smelc/lovelace-is-good branch August 13, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants