Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset balancing when minting #872

Closed
wants to merge 2 commits into from

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    <insert-changelog-description-here>
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fix #614

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/autobalance-when-minting branch from 825cade to c8d9311 Compare August 22, 2024 12:39
@carbolymer carbolymer marked this pull request as ready for review August 22, 2024 12:40
@carbolymer carbolymer marked this pull request as draft August 22, 2024 12:40
@carbolymer carbolymer changed the title Add test Fix asset balancing when minting Aug 22, 2024
@carbolymer carbolymer force-pushed the mgalazyn/fix/autobalance-when-minting branch from c8d9311 to 5a4fc02 Compare August 26, 2024 12:26
@carbolymer carbolymer force-pushed the mgalazyn/fix/autobalance-when-minting branch from 5a4fc02 to 45a2c20 Compare August 26, 2024 12:27
@carbolymer carbolymer closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect script budget estimation when minting assets and autobalancing a transaction
1 participant