Improve scripts/add-revions.sh #332
Conversation
hamishmack
force-pushed
the
hkm/dl-built-repo
branch
from
a9bb17b
to
859deb5
Compare
|
If we need to pass in a different |
| usage | ||
| exit 1 | ||
| fi | ||
|
|
||
| BUILT_REPO=$(mktemp -d) | ||
| mkdir -p $BUILT_REPO/index | ||
| curl -L https://input-output-hk.github.io/cardano-haskell-packages/01-index.tar.gz | tar -C $BUILT_REPO/index -xz |
There was a problem hiding this comment.
One can do
curl -L https://input-output-hk.github.io/cardano-haskell-packages/01-index.tar.gz | tar xvz cardano-cli/8.0.0/cardano-cli.cabal
``` to get the latest revision for `cardano-cli-8.0.0`.
There was a problem hiding this comment.
Or even
curl -L https://input-output-hk.github.io/cardano-haskell-packages/package/cardano-cli-8.0.0/cardano-cli.cabal
There was a problem hiding this comment.
Is this even correct? This downloads only the index. I guess that probably works in this case but I'm not sure. I think it would be safer to get the entire latest repository using one of the methods in https://github.com/input-output-hk/cardano-haskell-packages/pull/323
|
This won't work now if you need to add a revision to something that's not in the remote, or if you're doing multiple revisions to something. That's uncommon, but kind of important when you need it. We could wrap this in something that fetches the repository, it would be nice to keep the bare one also. |
The need to pass a `BUILT_REPO` arg is very confusing and it is small enough to just DL the latest to a temp dir. This change also only uses the `BUILT_REPO` if there is no existing revision. If there is a revision it copies the `.cabal` file from there (in case it is not in the BUILT_REPO yet). Also uses `date -u` instead of `date --utc` so that we don't have to install `gdate` on macOS to make it work.
andreabedini
force-pushed
the
hkm/dl-built-repo
branch
from
859deb5
to
6483506
Compare
The need to pass a
BUILT_REPOarg is very confusing and it is small enough to just DL the latest to a temp dir.This change also only uses the
BUILT_REPOif there is no existing revision. If there is a revision it copies the.cabalfile from there (in case it is not in the BUILT_REPO yet).Also uses
date -uinstead ofdate --utcso that we don't have to installgdateon macOS to make it work.