-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add Unsafe constructors for TxBody, TxBodyRaw and MemoBytes #4632
Draft
sgillespie
wants to merge
11
commits into
IntersectMBO:master
Choose a base branch
from
sgillespie:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
reviewed
Sep 16, 2024
Comment on lines
48
to
63
AlonzoTxBodyRaw ( | ||
UnsafeAlonzoTxBodyRaw, | ||
uatbInputs, | ||
uatbCollateral, | ||
uatbOutputs, | ||
uatbCerts, | ||
uatbWithdrawals, | ||
uatbTxFee, | ||
uatbValidityInterval, | ||
uatbUpdate, | ||
uatbReqSignerHashes, | ||
uatbMint, | ||
uatbScriptIntegrityHash, | ||
uatbAuxDataHash, | ||
uatbTxNetworkId | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This extra indirection is totally unnecessary
Suggested change
AlonzoTxBodyRaw ( | |
UnsafeAlonzoTxBodyRaw, | |
uatbInputs, | |
uatbCollateral, | |
uatbOutputs, | |
uatbCerts, | |
uatbWithdrawals, | |
uatbTxFee, | |
uatbValidityInterval, | |
uatbUpdate, | |
uatbReqSignerHashes, | |
uatbMint, | |
uatbScriptIntegrityHash, | |
uatbAuxDataHash, | |
uatbTxNetworkId | |
), | |
AlonzoTxBodyRaw (..) |
sgillespie
force-pushed
the
master
branch
2 times, most recently
from
September 19, 2024 17:37
018da64
to
6a38132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable replaying the ledger state with less memory for applications that only use staking/governance/events. Specifically, they can trim unnecessary information from blocks before applying them to the ledger state
Description
Checklist
CHANGELOG.md
for the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)