Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User typing additions #204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

User typing additions #204

wants to merge 2 commits into from

Conversation

TriggerAu
Copy link

Adjusted the routing on the Typing class to fix the SendTyping call and added a new class to receive the "user_typing" messages. For the second one I renamed the empty UserTyping method but maintained the scope etc

Hope the structure is good and if code comments are helpful just let me know

Relates/Fixes bug #203 that I logged when finding it

@TriggerAu
Remove "user_typing" from Typing Routes (Fixes Inumedia#203)
659eee1 
user_typing appears to be the event type for when a user is typing in a channel, and this class is being used to send the I am typing message - whose type is "typing"
@TriggerAu
Add UserTyping class and hookup action for user_typing event (Relates I…
a96b034 
…numedia#203)

filled in/renamed the UserTyping method so it matches the reaction/message ones. This now receives the events when a user is typing in a channel
@Inumedia
Copy link
Owner

Hey TriggerAu,

I'm not sure I understand the point of this PR other than to separate the receiving of this message from the sending of this message?

I don't mind the OnTyping event being added, but I am slightly concerned about the splitting of the receive/send of the event.

@TriggerAu
Copy link
Author

Thanks for lookingIll try and clarify how I got there.

The problem I struck was that on calling SendTyping the packet sent to the slackApi contained the message "user_typing" as the type to slack. It appeared to me that this was due to the WebSocketMessages class UserTyping.cs having two SlackSocketRouting attributes with different types "typing" and "user_typing". The only other class that was similar was newMessage.cs but the type is the same with one having a subtype.

Thus I split the sending and receiving type's to different classes. Hope that clarifies it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TriggerAu @Inumedia