Pr/250 Expand #250 to Enum #251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameter functionality in base response class.
Expands the use of conversations to use an enum when specifying request instead of pure string. Expands on Inumedia#250
Update the usage of #region to include additional areas and match between client and taskclient
|
Just to be clear, there's no actual functional changes to Client or TaskClient.cs, it is just making them match in their use of #region and making it the same order for the methods between the two since there were some differences. It does not gain or lose any functionality, but sets up to be able to implement the other Conversation methods in a clear way. |
|
Any update on this? |
|
I haven't had time to review all of the whitespace changes yet, I need to find a good tool to throw this into for easier diffing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the improvements from #250 to use an enum instead of pure string for specifying requests to new Conversations endpoint for user-friendliness.