Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
jfletcher-seclock committed Apr 7, 2024
1 parent 51ea063 commit bdc2787
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions src/Application/Results.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,15 @@
namespace JeroenG\Explorer\Application;

use Countable;
use Elastic\Elasticsearch\Response\Elasticsearch;

class Results implements Countable
{
private array $rawResults;

public function __construct(array $rawResults)
public function __construct(array|Elasticsearch $rawResults)
{
$this->rawResults = $rawResults;
$this->rawResults = $rawResults instanceof Elasticsearch ? $rawResults->asArray() : $rawResults;

Check warning on line 16 in src/Application/Results.php

View workflow job for this annotation

GitHub Actions / Mutation Testing Code Review Annotations 8.1

Escaped Mutant for Mutator "InstanceOf_": --- Original +++ New @@ @@ private array $rawResults; public function __construct(array|Elasticsearch $rawResults) { - $this->rawResults = $rawResults instanceof Elasticsearch ? $rawResults->asArray() : $rawResults; + $this->rawResults = false ? $rawResults->asArray() : $rawResults; } public function hits() : array {

Check warning on line 16 in src/Application/Results.php

View workflow job for this annotation

GitHub Actions / Mutation Testing Code Review Annotations 8.2

Escaped Mutant for Mutator "InstanceOf_": --- Original +++ New @@ @@ private array $rawResults; public function __construct(array|Elasticsearch $rawResults) { - $this->rawResults = $rawResults instanceof Elasticsearch ? $rawResults->asArray() : $rawResults; + $this->rawResults = false ? $rawResults->asArray() : $rawResults; } public function hits() : array {

Check warning on line 16 in src/Application/Results.php

View workflow job for this annotation

GitHub Actions / Mutation Testing Code Review Annotations 8.3

Escaped Mutant for Mutator "InstanceOf_": --- Original +++ New @@ @@ private array $rawResults; public function __construct(array|Elasticsearch $rawResults) { - $this->rawResults = $rawResults instanceof Elasticsearch ? $rawResults->asArray() : $rawResults; + $this->rawResults = false ? $rawResults->asArray() : $rawResults; } public function hits() : array {
}

public function hits(): array
Expand Down
2 changes: 1 addition & 1 deletion src/Infrastructure/Elastic/Finder.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ public function find(): Results

$rawResults = $this->client->search($query);

return new Results($rawResults->asArray());
return new Results($rawResults);
}
}

0 comments on commit bdc2787

Please sign in to comment.