Merge pull request #217 from Jeroen-G/fix-sort-tests-on-master

Fix sort related tests
Jeroen-G · Sep 22, 2023 · e39853f · e39853f
2 parents 13f4656 + 38f0c75
commit e39853f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Infrastructure/Scout/ScoutSearchCommandBuilder.php b/src/Infrastructure/Scout/ScoutSearchCommandBuilder.php
@@ -34,7 +34,7 @@ class ScoutSearchCommandBuilder implements SearchCommandInterface
 
     private ?string $minimumShouldMatch = null;
 
-    /** @var SyntaxInterface[]  */
+    /** @var Sort[]  */
     private array $sort = [];
 
     private array $aggregations = [];
@@ -208,7 +208,7 @@ public function setLimit(?int $limit): void
 
     public function setSort(array $sort): void
     {
-        Assert::allIsInstanceOf($sort, SyntaxInterface::class);
+        Assert::allIsInstanceOf($sort, Sort::class);
         $this->sort = $sort;
     }
 
@@ -305,11 +305,11 @@ public function getOffset(): ?int
         return $this->offset;
     }
 
-    /** @return SyntaxInterface[] */
+    /** @return Sort[] */
     private static function getSorts(Builder $builder): array
     {
         return array_map(static function($order) {
-            return $order instanceof SyntaxInterface ? $order : new Sort($order['column'], $order['direction']);
+            return $order instanceof Sort ? $order : new Sort($order['column'], $order['direction']);
         }, $builder->orders);
     }
 }
diff --git a/tests/Unit/ScoutSearchCommandBuilderTest.php b/tests/Unit/ScoutSearchCommandBuilderTest.php
@@ -140,12 +140,12 @@ public function test_it_can_set_the_sort_order(): void
         $command->setSort([new Sort('id', 'invalid')]);
     }
 
-    public function test_it_only_accepts_syntax_interface_classes(): void
+    public function test_it_only_accepts_sort_classes(): void
     {
         $command = new ScoutSearchCommandBuilder();
 
         $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('Expected an instance of JeroenG\Explorer\Domain\Syntax\SyntaxInterface. Got: string');
+        $this->expectExceptionMessage('Expected an instance of JeroenG\Explorer\Domain\Syntax\Sort. Got: string');
 
         $command->setSort(['not' => 'a class']);
     }