Elasticsearch ^8.0 support #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumb es version
looks like will need to update all the tests to use Http client
|
Been testing this locally and seems to be working fine, any possible traction on merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains breaking changes.
Elasticsearch 8.x introduced many breaking changes to the client. It seems to have been a complete overhaul.
8.x also introduced the native Client from ClientBuilder so there is no longer a need for the following files:
src/Infrastructure/Elastic/ElasticClientFactory.php - removed
src/Infrastructure/Elastic/ElasticClientBuilder.php- removed
and associated tests:
tests/Unit/ElasticClientBuilderTest.php - removed
tests/Unit/ElasticClientFactoryTest.php - removed
Client can now be injected via native ClientBuilder so ElasticClientBuilder was replaced with Elastic's native ClientBuilder and documentation has been updated to reflect this.
Also this updates tests to match how Elasticsearch suggests you mock their requests (using Guzzle in this case, see changes in FinderTest.php)
this is an expansion on #239 getting all the CI to work properly