-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] feat: replace all teams filter in remaining pages #3111
base: feat/enhanced-dashboard
Are you sure you want to change the base?
[Dashboard] feat: replace all teams filter in remaining pages #3111
Conversation
612433e
to
963336c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smashed another one @bassgeta 💪 👏
Tested and can confirm the new filters are present on the mentioned pages
I know you didn't touch these pages, but can confirm the domain filters is not present on the Extensions or Profile pages
After leaving the refactoring comments for consistency, I'm wondering if it wouldn't make sense to create a new component and just wrap the pages needing the domain filter. What do you think @bassgeta? 😁
const ContentWithDomainFilter: FC<PropsWithChildren> = ({ children }) => {
return (
<div className="flex flex-col gap-8">
<TeamFilter />
{children}
</div>
)
}
<div className="flex w-full flex-col gap-4 sm:gap-6"> | ||
<div className="mb-2"> | ||
<TeamFilter /> | ||
</div> | ||
<WidgetBoxList items={widgets} /> | ||
<div> | ||
<FiltersContextProvider> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, would suggest to wrap the previous content as you did on the previous pages
<div className="flex flex-col gap-8">
<TeamFilter />
...previous page content here
</div>
@@ -54,6 +49,9 @@ const AgreementsPage: FC = () => { | |||
|
|||
return ( | |||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well
<div className="flex flex-col gap-8">
<TeamFilter />
...previous page content here
</div>
<div className="flex flex-col gap-8"> | ||
<TeamFilter /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well
<div className="flex flex-col gap-8">
<TeamFilter />
...previous page content here
</div>
<div className="flex w-full flex-col gap-6"> | ||
<div className="mb-2"> | ||
<TeamFilter /> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well
<div className="flex flex-col gap-8">
<TeamFilter />
...previous page content here
</div>
Feat: add nivo chart packages
…Information component
Refactor: Changes after review
Feat: Add balance in/out bar chart
Feat: Update reputation chart values
…, the magic disappearer component
Feat: add payments and income sections to TotalInOutBalance card
Refactor: Update fundsClaimedCTA copy text
Refactor: changes after review
Refactor: Update ClaimFundsButton for claimed funds
1400d51
to
cb08bb7
Compare
963336c
to
6b8a1c6
Compare
[Dashboard] fix: rename fundsClaims to fundsClaimData because of the index bug
… new one on all pages
6b8a1c6
to
163fd91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d10cf57
to
4476c6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job once again @bassgeta!
It's nice that now the breadcrumbs can just be breadcrumbs 😆 It makes it much simpler! Also agree with the approach of the reusable wrapper component, it's very nice.
It looks like you need to rebase, but I checked the code by just looking at your actual commits and it all looks good. Also tested all the pages you mentioned (including mobile) and everything is as expected! Let's gooo.
Description
Replace the old breadcrumb navigation with the new filter component!
Figma link
Testing
Basically go to the following pages and make sure that the filter still works and that it displays nicely
And do note there's one layout bug present but it's being fixed elsewhere
When the screen gets wide, the filter is stuck with the content, but the title stays on the lefthand side.
Diffs
Changes 🏗
TeamFilter
component to the 7 pages aboveDeletions ⚰️
BreadcrumbsCardSelect
componentuseTeamsBreadcrumbs
hookResolves #2860