Fix #368929: Crash on playback with hidden staves and 'superfluous' voltas #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
changed the title
Jojo-Schmitz
changed the title
4 tasks
|
Seems more like pure luck (or lack thereof) whether this fixes the crash or not. |
Jojo-Schmitz
force-pushed
the
3.x-playback-hidden-staff-volta-crash
branch
from
5927914
to
d0201e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/368929
Resolves: musescore#24802
Not exactly sure what the deal is here, but the crash does happen while processing voltas, and the score does have them for both visible staves, and is also having some invisible staves (without voltas).
Just making the invisible staves visible fixes the crash, just removing the 'superfluous' voltas does not.
This PR just does some sanity checks before dereferencing
thispointers, so is more like band aid rather than a real fix.