Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge and generalize overapproximate methods with HPolytope #844

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

schillic
Copy link
Member

@schillic schillic commented Jun 16, 2024

The implementation was not specific to Hyperrectangles at all, so I generalized it.

@schillic schillic marked this pull request as ready for review June 16, 2024 09:31
@mforets
Copy link
Member

mforets commented Aug 27, 2024

did you consider whether it would make sense to move this to LazySets ?

actually, this looks like something that should already exist in lazysets.

@mforets
Copy link
Member

mforets commented Aug 27, 2024

ok, it seems that _overapproximate is used here as an intermediate level of dispatch.

@schillic
Copy link
Member Author

You mean this could just be removed? I did not try.

@mforets mforets merged commit 352787a into master Aug 28, 2024
6 checks passed
@mforets mforets deleted the schillic/overapproximate branch August 28, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants