Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

axes(::ReshapedDistribution) should throw, added missing ndims #1892

Closed
wants to merge 12 commits into from
Closed

axes(::ReshapedDistribution) should throw, added missing ndims #1892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f1016e9
add missing axes(::ReshapedDistribution, k) method
stevengj Aug 30, 2024
81dacfe
Update matrixreshaped.jl
stevengj Aug 30, 2024
a261c03
add ndims(::ReshapedDistribution)
stevengj Aug 30, 2024
dbfdf4d
Base.oneto does not exist in julia 1.3
stevengj Aug 30, 2024
4d7cc53
Base.oneto does not exist in julia 1.3
stevengj Aug 30, 2024
35deea6
simplify test
stevengj Aug 30, 2024
e09aac8
Update matrixreshaped.jl: test fix
stevengj Aug 30, 2024
2a02978
Update reshaped.jl
stevengj Aug 30, 2024
503b5b9
Update matrixreshaped.jl
stevengj Aug 30, 2024
1841985
Update matrixreshaped.jl: missing test
stevengj Aug 30, 2024
6823662
rm axes
stevengj Aug 30, 2024
adbfadf
rm axes
stevengj Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/reshaped.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ end

Base.size(d::ReshapedDistribution) = d.dims
Base.eltype(::Type{ReshapedDistribution{<:Any,<:ValueSupport,D}}) where {D} = eltype(D)
Base.ndims(d::ReshapedDistribution{N}) where {N} = N

partype(d::ReshapedDistribution) = partype(d.dist)
params(d::ReshapedDistribution) = (d.dist, d.dims)
Expand Down
6 changes: 6 additions & 0 deletions test/matrixreshaped.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,18 @@ function test_matrixreshaped(rng, d1, sizes)
for (d, s) in zip(d1s[1:end-1], sizes[1:end-1])
@test size(d) == s
end
@test size(d1s[end]) == (sizes[end][1], sizes[end][1])
end
@testset "MatrixReshaped length" begin
for d in d1s
@test length(d) == length(d1)
end
end
@testset "MatrixReshaped ndims" begin
for d in d1s
@test ndims(d) == 2
end
end
@testset "MatrixReshaped rank" begin
for (d, s) in zip(d1s, sizes)
@test rank(d) == minimum(s)
Expand Down
Loading