Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pairwise multi-threaded and make corkendall and corspearman wrap pairwise. #923

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Make pairwise multi-threaded and make corkendall and corspearman wrap pairwise. #923

wants to merge 24 commits into from

Commits on Mar 30, 2024

  1. Rewrite pairwise, corkendall and corspearman

    @PGS62
    PGS62 committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    c85116a View commit details
    Browse the repository at this point in the history

  2. Delete rankcorrspeedtest.jl

    @PGS62
    PGS62 committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    8ced336 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Partial solution to test failures on Julia 1.0.5

    @PGS62
    PGS62 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    6a8fecd View commit details
    Browse the repository at this point in the history

  2. Reverted to using eachcol in the hope that support for Julia 1.0.5 wi… 

    …ll be dropped.
    @PGS62
    PGS62 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    eff32e4 View commit details
    Browse the repository at this point in the history

  3. Deleted commented out tests

    @PGS62
    PGS62 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    1a4d064 View commit details
    Browse the repository at this point in the history

  4. Delete settings.json

    @PGS62
    PGS62 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    893d4b6 View commit details
    Browse the repository at this point in the history

  5. Update pairwise.jl in response to some of devmotion's comments

    @PGS62
    PGS62 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    e2c9ef5 View commit details
    Browse the repository at this point in the history

  6. Was calling copytry! too soon. Fixed that.

    @PGS62
    PGS62 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    4c2e7a0 View commit details
    Browse the repository at this point in the history

  7. Update pairwise.jl

    @PGS62
    PGS62 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    2119804 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. nested loops more friendly to Julia being column-major

    @PGS62
    PGS62 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5da5943 View commit details
    Browse the repository at this point in the history

  2. flipped i and j loop variables. reshape -> similar

    @PGS62
    PGS62 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    baf193b View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Added iterators EqualSumSubsets and TwoStepRange

    @PGS62
    PGS62 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    a1d9ae9 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Int64 -> Int to work on 32bit

    @PGS62
    PGS62 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    951b391 View commit details
    Browse the repository at this point in the history

  2. Update tests

    @PGS62
    PGS62 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    75d206a View commit details
    Browse the repository at this point in the history

  3. Update tests

    @PGS62
    PGS62 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    56d27cc View commit details
    Browse the repository at this point in the history

  4. Tests now pass on Julia 1.8.5 

    No longer use eachcol when VERSION < v"1.9"
    @PGS62
    PGS62 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    682859a View commit details
    Browse the repository at this point in the history

  5. Compatibility with Julia 1.6

    @PGS62
    PGS62 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    9c039dd View commit details
    Browse the repository at this point in the history

  6. Test against Julia 1.6, 1.7, 1.8 and 1.9 to find possible new minimum… 

    … version
    @PGS62
    PGS62 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    f53b7b5 View commit details
    Browse the repository at this point in the history

  7. Test on Julia 1.1, 1.2, 1.3. 1.4 and 1.5

    @PGS62
    PGS62 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    88bf8f6 View commit details
    Browse the repository at this point in the history

  8. Demonstrate that 1.6 could be new minimum version

    @PGS62
    PGS62 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    ddb1b51 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. Corrected call to keyword argument

    @PGS62
    PGS62 committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    f67e867 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Improved test coverage (src/pairwise.jl#L84-L87)

    @PGS62
    PGS62 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    246f32d View commit details
    Browse the repository at this point in the history

  2. Improved test coverage (StatsBase._cor)

    @PGS62
    PGS62 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    46d5655 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Trivial change to re-run tests

    @PGS62
    PGS62 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    e1395b8 View commit details
    Browse the repository at this point in the history