Fix 1D buffer image tests #2073
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer size needs to be greater than or equal the image row pitch which was not the case.
ahesham-arm
commented
Sep 6, 2024
| @@ -67,9 +67,7 @@ static int test_get_1Dimage_buffer_info_single(cl_context context, | |||
| if (gDebugTrace) | |||
| log_info(" - Creating 1D image %d ...\n", (int)imageInfo->width); | |||
|
|
|||
| buffer = clCreateBuffer( | |||
| context, flags, imageInfo->width * get_pixel_size(imageInfo->format), | |||
There was a problem hiding this comment.
This seems to be the correct calculation but line 264 in this file modifies this value as such:
do
{
extraWidth++;
imageInfo.rowPitch += extraWidth;
} while ((imageInfo.rowPitch % pixelSize) != 0);
|
Thanks, this addresses the issues we saw in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer size needs to be greater than or equal the image row pitch which was not the case.