Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small clarification to buffer sync rules #291

Merged

Commits on Oct 4, 2022

  1. Small clarification to buffer sync rules

    The section on buffer synchronization rules define the scenarios when
    the buffer destructor must block vs. the scenarios where it does not
    block.  The old wording made it seem like a buffer created from no host
    pointer is only non-blocking if it uses the default memory allocator.
    I assume this was not our intent, and such a buffer should have a
    non-blocking destructor regardless of the memory allocator.
    
    The main change in this PR is to remove the phrase "and using the
    default buffer allocator".  However, I also reworded a bit to clarify
    which type of buffers we are talking about.
    gmlueck committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    15a32de View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Addess review comment, clarify wording

    Avoid the word "mapped" and say "used to construct" instead.
    gmlueck committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    87a71b1 View commit details
    Browse the repository at this point in the history
  2. Clarify buffer allocator lifetime

    Clarify that the implementation may keep a copy of a buffer allocator
    even after the buffer is destroyed.
    gmlueck committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    f4f70c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Small change in wording

    Co-authored-by: Ronan Keryell <[email protected]>
    gmlueck and keryell committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    4b8b67d View commit details
    Browse the repository at this point in the history