Clarify and deprecate "execution_capabilities" #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a customer bug report about the behavior of `info::device::execution_capabilities` for non-OpenCL devices. It turns out that the spec isn't clear about this. This PR clarifies that an exception should be thrown, which is consistent with our behavior for `info::device::profile` and `info::device::preferred_interop_user_sync`, which are also inherited from OpenCL. Another option would be to return an empty vector, so we could debate that if people think that's better. I also think we should deprecate this query, which is consistent with the other queries that are specific to the OpenCL backend. This PR deprecates the query in SYCL-NEXT, though I would also be open to retroactively deprecating it in SYCL 2020 with the rationale that we deprecated the other OpenCL-specific queries and simply forgot this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a customer bug report about the behavior of
info::device::execution_capabilitiesfor non-OpenCL devices. It turns out that the spec isn't clear about this. This PR clarifies that an exception should be thrown, which is consistent with our behavior forinfo::device::profileandinfo::device::preferred_interop_user_sync, which are also inherited from OpenCL. Another option would be to return an empty vector, so we could debate that if people think that's better.I also think we should deprecate this query, which is consistent with the other queries that are specific to the OpenCL backend. This PR deprecates the query in SYCL-NEXT, though I would also be open to retroactively deprecating it in SYCL 2020 with the rationale that we deprecated the other OpenCL-specific queries and simply forgot this one.