Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3-tap-to-hide GUI gesture #932

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoseEmilio-ARM
Copy link
Collaborator

Description

#672 disabled the click/tap gesture to hide the UI. On smaller screens, particularly when more than 2 lanes of stats are enabled (in Performance samples), the UI takes most of the space, and does not allow to inspect the rendered scene in detail. In this case, it would still be useful to have a way to hide it.

To avoid accidentally hiding the UI when panning the camera, this change re-introduces the gesture, but as a 3-finger tap, so that it is more intentional (a 2-finger tap can still be used to display the debug window in Performance samples).

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

@gary-sweet
Copy link
Contributor

I can confirm that this builds for me without issue, but I can't test it as I can't run on Android.

Copy link
Collaborator

@tomadamatkinson tomadamatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@asuessenbach
Copy link
Contributor

Is it correct, that you'd keep *_finger_tap true when you press_down with 2 touch points but press_up with a different number of touch points? Can that happen at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants