Bug fix: make dismiss during export not fire success toast #3882
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Need a bit of tweaking to make playwright tests behave nicely |
I guess that makes sense, the toast sits there for slightly longer now right? |
|
Makes me think if this should even be time-based, or any of our modals. What if the user misses it while they are away? A modal should be an occasional occurrence, right? Having the user dismiss could have benefits. |
It's a good thought. I think having some toasts require dismissal is a good idea, but I do believe some are just like yeah you successfully did the thing, such as changing a setting, that I don't think we'd want to require a click to dismiss. If we made the toasts smaller/more subtle, I think we could have the timer on them a fair bit longer, and show a loading bar for how much longer it'll appear. I think Sanity does this well, I could get a video of it at some point. |
|
Good lord finally, my CI struggle has been real |
Fixes #3542 by moving the toast firing logic out of the ModelingMachineProvider and into the export helper functions. We can do this thanks to react-hot-toast's helpfully React-agnostic API, and
exportMakewas already doing this to fire customtoast.error's. By doing this, we can simply dismiss the toast on cancellation during desktop export.Demo
Screenshare.-.2024-09-13.4_22_19.PM-compressed.mp4