Replace kittycad crate with kittycad-modeling-cmds #3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adamchalmers
force-pushed
the
achalmers/use-modeling-api
branch
from
1a31db3
to
5b36f4d
Compare
adamchalmers
force-pushed
the
achalmers/use-modeling-api
branch
from
5b36f4d
to
2c44383
Compare
adamchalmers
changed the title
adamchalmers
force-pushed
the
achalmers/use-modeling-api
branch
2 times, most recently
from
31d5123
to
75622e8
Compare
adamchalmers
force-pushed
the
achalmers/use-modeling-api
branch
2 times, most recently
from
faa1441
to
a5b8cb8
Compare
adamchalmers
commented
Sep 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3909 +/- ##
==========================================
- Coverage 87.25% 87.21% -0.05%
==========================================
Files 69 69
Lines 25120 25103 -17
==========================================
- Hits 21919 21894 -25
- Misses 3201 3209 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lib.rs/kittycad-modeling-cmds is the source of our Modeling API. It gets included in our backend APIs, and those APIs generate OpenAPI specs which are read by `openapitor` which generates the lib.rs/kittycad crate. So basically, our modeling app is using the _generated code_ instead of the _handwritten code_. This sucks -- if you add a new field to the modeling-api crate, you have to merge PRs to the engine, api-deux, and kittycad.rs before finally you can get the new field into the modeling-app. I was pretty embarrased when Mike asked how to get a new field into the modeling app and had to explain this whole bullshit cycle. Let's fix it. Switching to use the kittycad-modeling-cmds (aka kcmc) crate directly should speed up our dev cycle.
adamchalmers
force-pushed
the
achalmers/use-modeling-api
branch
from
a5b8cb8
to
37e5da0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib.rs/kittycad-modeling-cmds is the source of our Modeling API. It gets included in our backend APIs, and those APIs generate OpenAPI specs which are read by
openapitorwhich generates the lib.rs/kittycad crate. So basically, our modeling app is using the generated code instead of the handwritten code.This sucks -- if you add a new field to the modeling-api crate, you have to merge PRs to the engine, api-deux, and kittycad.rs before finally you can get the new field into the modeling-app. I was pretty embarrased when @mlfarrell asked how to get a new field into the modeling app and had to explain this whole bullshit cycle. Let's fix it.
Switching to use the kittycad-modeling-cmds (aka kcmc) crate directly should speed up our dev cycle.