Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dumb ass logic bug with edge cuts, actually extends edge cuts array versus overwriting it lolz #3928

Merged
merged 9 commits into from
Sep 19, 2024

Conversation

jessfraz
Copy link
Contributor

closes #3919

Copy link

qa-wolf bot commented Sep 19, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Sep 19, 2024 10:03pm

Signed-off-by: Jess Frazelle <[email protected]>
@jessfraz jessfraz merged commit d1f9a02 into main Sep 19, 2024
9 of 10 checks passed
@jessfraz jessfraz deleted the logic-bug branch September 19, 2024 21:50
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.21%. Comparing base (370375c) to head (3235c28).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3928   +/-   ##
=======================================
  Coverage   87.21%   87.21%           
=======================================
  Files          69       69           
  Lines       25103    25103           
=======================================
  Hits        21894    21894           
  Misses       3209     3209           
Flag Coverage Δ
wasm-lib 87.21% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Irev-Dev Irev-Dev mentioned this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sketch on chamfer wigs out on second chamfer
2 participants