Bump PHPUnit version to 10 #340
Conversation
README.md
Outdated
| @@ -9,7 +9,7 @@ fancy paginator component | |||
|
|
|||
| ## Running unit tests | |||
|
|
|||
| PHPUnit 9 or newer is required. | |||
| PHPUnit 10 or newer is required. | |||
There was a problem hiding this comment.
This should be changed (it was wrong in the previous version too). We can't guarantee that tests will work with PHPUnit 11, so we need to remove the "or newer" clause.
If, instead, you manage to get the tests working with both, let's change the requirements to include version 11 too.
There was a problem hiding this comment.
Tests work with PHPUnit 10 and 11.
I have updated the README accordingly.
There was a problem hiding this comment.
Tests work with PHPUnit 10 and 11. I have updated the README accordingly.
Forgive my scepticism, but I need to see the tests (and I can't, as long as we don't allow PHPUnit 11)
There was a problem hiding this comment.
Sorry, I forgot to mentioned that I have also allowed the installation of PHPUnit 11.
In PHP 8.1, tests are using PHPUnit 10, in higher PHP versions, PHPUnit 11 is used (see https://github.com/KnpLabs/knp-components/actions/runs/10227239091/job/28298482755?pr=340).
I have updated the rule sets regarding PHP and PHPUnit |
#339 dropped support PHP 8.0 and made it possible to bump the PHPUnit version.