fix: default konnect url with konnect addr flag not accounted for. #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a deck command was issued with --konnect-addr flag but with the default konnectUrl https://us.api.konghq.com, the flag value was getting ignored as deck could not figure out if it was passed by flag or not. This change ensures that if the flag is set, deck commands are issued against Konnect. Fixes: #1385
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
==========================================
- Coverage 29.16% 29.08% -0.08%
==========================================
Files 59 59
Lines 5211 5215 +4
==========================================
- Hits 1520 1517 -3
- Misses 3583 3589 +6
- Partials 108 109 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a deck command was issued with --konnect-addr flag but with the default konnectUrl https://us.api.konghq.com, the flag value was getting ignored as deck could not figure out if it was passed by flag or not. This change ensures that if the flag is set, deck commands are issued against Konnect.
Fixes: #1385