Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split tox jobs #1548

Merged
merged 2 commits into from
Jul 25, 2024
Merged

split tox jobs #1548

merged 2 commits into from
Jul 25, 2024

Conversation

deronnax
Copy link
Contributor

@deronnax deronnax commented Jul 24, 2024

You don't need to run isort, mypy and flake8 as many time as you have environments (~20 here).

  • you save yourself Github Actions CI minutes (the Windows one count double and macOS count 4 times)
  • you get faster feedback (the ubuntu 3.11 test one runs under 20 seconds)(we could probably stop the test matrix as soon as this one fail, to avoid useless runs).
  • no more dirty python / mypy version check hack.
  • you save the planet

Btw, mypy, isort and flake8 version should be pinned. If not, you are at risk than any new release of any of those 3 turns your CI red overnight.

@deronnax deronnax marked this pull request as ready for review July 24, 2024 22:09
@deronnax deronnax force-pushed the split-tox-jobs branch 3 times, most recently from 6c383d6 to fe16df5 Compare July 24, 2024 22:20
@pbiering pbiering self-assigned this Jul 25, 2024
@pbiering pbiering added this to the 3.2.3 milestone Jul 25, 2024
@pbiering pbiering self-requested a review July 25, 2024 06:19
@pbiering
Copy link
Collaborator

Btw, mypy, isort and flake8 version should be pinned. If not, you are at risk than any new release of any of those 3 turns your CI red overnight.

can you add this also to this PR (similar happened already in the past with "Python 3.12.3->3.12.4")

https://github.com/Kozea/Radicale/pull/1538/files

and related to "tox":

[tox:tox]
min_version = 4.0

Is there also a max_version supported?

@deronnax
Copy link
Contributor Author

Pinning done. And no, there is no tox max_version. Why so?

@pbiering
Copy link
Collaborator

Pinning done.

Thank you!

And no, there is no tox max_version. Why so?

Avoid that e.g. 5.0 causes broken builds...but potentially "tox" is not "playing the game" with developers as others do by introducing breaking changes or add new strong dependencies in even sub-minor releases.

Copy link
Collaborator

@pbiering pbiering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@pbiering pbiering merged commit 897a679 into Kozea:master Jul 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants