Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adventure to 4.14.0 #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Phoenix616
Copy link

Did some (basic) testing and it seems to work just fine.

@qixils
Copy link

qixils commented Jun 15, 2023

Adventure 4.14.0 has new APIs that need to be supported.

@zml2008
Copy link
Member

zml2008 commented Jun 15, 2023

Additionally, there is some newly-deprecated api in 4.14.0 that is relatively trivial to update for if you're able to do that

@Phoenix616
Copy link
Author

Phoenix616 commented Jun 17, 2023

Adventure 4.14.0 has new APIs that need to be supported.

Someone more knowledgeable of the whole platform design might need to take a look at adding those features as I'm not quite sure how to implement those changes in the platform adaptors or how the adaptor design works in general. E.g. as far as I can tell net.kyori.adventure.bossbar.BossBar is never actually implemented anywhere by the facets or adaptors, only BossBar.Listener is. Is the idea to add methods to that? Then how would they be accessible from the normal API methods? Also would the FacetAudience need to implement BossBarViewer interface?


On an unrelated note to the PR (but which makes it harder for me to work on this): The overall code base is very hard to read for me as it uses 2 space indention and unfortunately I need more indention to properly differentiate code. (And of course hard-coded spaces as indention can not as easily adjusted to one's visual needs as tabs could :S)

EDIT: I love that I first try googling, don't find anything then after writing a bit about it end up finding a solution too. If anyone ever runs into similar issues, here is an InteliiJ plugin which solves that: https://plugins.jetbrains.com/plugin/14849-elastic-indents/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants