Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up MixerChannelView #7431

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Tidy up MixerChannelView #7431

wants to merge 11 commits into from

Conversation

sakertooth
Copy link
Contributor

I realized we merged the MixerChannelView addition, but the formatting wasn't correct. Also did some minor cleanup with headers and header guards.

Rossmaxx
Rossmaxx reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@Rossmaxx Rossmaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is it for now.

include/MixerChannelView.h Show resolved Hide resolved
src/gui/MixerChannelView.cpp Show resolved Hide resolved
messmerd
messmerd reviewed Sep 13, 2024
View reviewed changes
include/MixerChannelView.h Outdated Show resolved Hide resolved
include/MixerChannelView.h Outdated Show resolved Hide resolved
messmerd
messmerd reviewed Sep 14, 2024
View reviewed changes
src/gui/MixerChannelView.cpp Outdated Show resolved Hide resolved
include/MixerChannelView.h Outdated Show resolved Hide resolved
@sakertooth sakertooth changed the title Reformat MixerChannelView.cpp and MixerChannelView.h Fix up MixerChannelView Sep 14, 2024
@sakertooth sakertooth marked this pull request as draft September 17, 2024 17:44
@sakertooth sakertooth marked this pull request as ready for review September 17, 2024 17:56
@sakertooth sakertooth changed the title Fix up MixerChannelView Tidy up MixerChannelView Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messmerd messmerd messmerd left review comments

@Rossmaxx Rossmaxx Rossmaxx left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sakertooth @messmerd @Rossmaxx