Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add splitting to all types of clips #7477

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Add splitting to all types of clips #7477

wants to merge 38 commits into from
+197 −39

Commits on Aug 31, 2024

  1. Initial clip splitting

    @regulus79
    regulus79 committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    09fccac View commit details
    Browse the repository at this point in the history

  2. Force midi clip splitting to be roudned to 1 bar

    @regulus79
    regulus79 committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    e010f28 View commit details
    Browse the repository at this point in the history

  3. Make midi clip split into two clips and delete the old, instead of tr… 

    …ying to remove notes from current clip
    @regulus79
    regulus79 committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    ff8a47d View commit details
    Browse the repository at this point in the history

  4. Change splitting automation clips to be like midi clips: spawning two… 

    … new, removing the old.
    @regulus79
    regulus79 committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    8767dfd View commit details
    Browse the repository at this point in the history

  5. Remove unecessary spacing and replace iterator type with auto

    @regulus79
    regulus79 committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    fb2a222 View commit details
    Browse the repository at this point in the history

  6. Invert if statement to return false early

    @regulus79
    regulus79 committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    70cf4dc View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Separate brackets from code with space 

    Co-authored-by: szeli1 <[email protected]>
    @regulus79 @szeli1
    regulus79 and szeli1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    06b645e View commit details
    Browse the repository at this point in the history

  2. Add space between for and parentheses 

    Co-authored-by: szeli1 <[email protected]>
    @regulus79 @szeli1
    regulus79 and szeli1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    4afdc87 View commit details
    Browse the repository at this point in the history

  3. Change spacing in if statment 

    Co-authored-by: szeli1 <[email protected]>
    @regulus79 @szeli1
    regulus79 and szeli1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    c287cd0 View commit details
    Browse the repository at this point in the history

  4. Make param comment multiline 

    Co-authored-by: szeli1 <[email protected]>
    @regulus79 @szeli1
    regulus79 and szeli1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    0f92817 View commit details
    Browse the repository at this point in the history

  5. Add spaces between // and comments 

    Co-authored-by: szeli1 <[email protected]>
    @regulus79 @szeli1
    regulus79 and szeli1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6108c5d View commit details
    Browse the repository at this point in the history

  6. Add space between if and parentheses 

    Co-authored-by: szeli1 <[email protected]>
    @regulus79 @szeli1
    regulus79 and szeli1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    360a5d1 View commit details
    Browse the repository at this point in the history

  7. Remove space between const and * 

    Co-authored-by: szeli1 <[email protected]>
    @regulus79 @szeli1
    regulus79 and szeli1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    273520c View commit details
    Browse the repository at this point in the history

  8. Remove space between const and star again 

    Co-authored-by: szeli1 <[email protected]>
    @regulus79 @szeli1
    regulus79 and szeli1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    607e810 View commit details
    Browse the repository at this point in the history

  9. Change code style for the other clip types

    @regulus79
    regulus79 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    790a01f View commit details
    Browse the repository at this point in the history

  10. Code style changes for SampleClipView, plus inverting the if statement

    @regulus79
    regulus79 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    1c45810 View commit details
    Browse the repository at this point in the history

  11. Update comment in ClipView.h

    @regulus79
    regulus79 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    292e998 View commit details
    Browse the repository at this point in the history

  12. Remove comments from .cpp files, and add single comment in ClipView.h

    @regulus79
    regulus79 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    da2e97c View commit details
    Browse the repository at this point in the history

  13. Make rounded_pos lowerCamelCase

    @regulus79
    regulus79 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    c1f2928 View commit details
    Browse the repository at this point in the history

  14. Declare movedNote on the stack

    @regulus79
    regulus79 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    de01890 View commit details
    Browse the repository at this point in the history

  15. Force left clip to remain at original position after splitting

    @regulus79
    regulus79 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2995ba8 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Change Knife Mode button tooltip

    @regulus79
    regulus79 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    72356bf View commit details
    Browse the repository at this point in the history

  2. Make knife cursor appear for all types of clips

    @regulus79
    regulus79 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ac8a1c4 View commit details
    Browse the repository at this point in the history

  3. Make double-click do nothing when in knife mode

    @regulus79
    regulus79 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    19b6916 View commit details
    Browse the repository at this point in the history

  4. Fix midi clips having wrong length after splitting

    @regulus79
    regulus79 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b2db31a View commit details
    Browse the repository at this point in the history

  5. Remove spaces to fix code style

    @regulus79
    regulus79 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    aa773a0 View commit details
    Browse the repository at this point in the history

  6. Use removeNodes() instead of recreating entire left clip

    @regulus79
    regulus79 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    39a8bb3 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Add split marker to all clip types, and remove bar rounding on midi c… 

    …lips
    @regulus79
    regulus79 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a39be95 View commit details
    Browse the repository at this point in the history

  2. Do not populate notes as quantized in the new midi clips

    @regulus79
    regulus79 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8f3955a View commit details
    Browse the repository at this point in the history

  3. Change remove() to close() to fix undoing bug

    @regulus79
    regulus79 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    df5b49b View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Remove spaces to fix code style

    @regulus79
    regulus79 committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    bf7d1f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Make splitClip() pure virtual

    @regulus79
    regulus79 committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    6d13da1 View commit details
    Browse the repository at this point in the history

  2. Remove whitespace 

    Co-authored-by: Dalton Messmer <[email protected]>
    @regulus79 @messmerd
    regulus79 and messmerd committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    19837bc View commit details
    Browse the repository at this point in the history

  3. Remove whitespace from PatternClipView 

    Co-authored-by: Dalton Messmer <[email protected]>
    @regulus79 @messmerd
    regulus79 and messmerd committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    f8b763c View commit details
    Browse the repository at this point in the history

  4. Remove whitespace from AutomationClipView 

    Co-authored-by: Dalton Messmer <[email protected]>
    @regulus79 @messmerd
    regulus79 and messmerd committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    7974445 View commit details
    Browse the repository at this point in the history

  5. Remove whitespace from ClipView 

    Co-authored-by: Dalton Messmer <[email protected]>
    @regulus79 @messmerd
    regulus79 and messmerd committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    650b8b4 View commit details
    Browse the repository at this point in the history

  6. Initialize variables in AutomationClip's copy constructor

    @regulus79
    regulus79 committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    858330a View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Use remove() instead of close() to solve problem of midi clip playing… 

    … after deletion
    @regulus79
    regulus79 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e1269e7 View commit details
    Browse the repository at this point in the history