Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Effect processing #7484

Merged
merged 17 commits into from
Sep 21, 2024
Merged

Refactor Effect processing #7484

merged 17 commits into from
Sep 21, 2024

Commits on Sep 2, 2024

  1. Move common effect processing code to wrapper method 

    - Introduce `processImpl` and `sleepImpl` methods, and adapt each effect
plugin to use them
- Use double for RMS out sum in Compressor and LOMM
- Run `checkGate` for GranularPitchShifterEffect
- Minor changes to LadspaEffect
- Remove dynamic allocations and VLAs from VstEffect's process method
- Some minor style/formatting fixes
    @messmerd
    messmerd committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a7e8af6 View commit details
    Browse the repository at this point in the history

  2. Fix VstEffect regression

    @messmerd
    messmerd committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    51647ff View commit details
    Browse the repository at this point in the history

  3. GranularPitchShifterEffect should not call checkGate

    @messmerd
    messmerd committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    67526f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Apply suggestions from code review 

    Co-authored-by: saker <[email protected]>
    @messmerd @sakertooth
    messmerd and sakertooth committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    cf99a6d View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Follow naming convention for local variables

    @messmerd
    messmerd committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5993030 View commit details
    Browse the repository at this point in the history

  2. Add MAXIMUM_BUFFER_SIZE and use it in VstEffect

    @messmerd
    messmerd committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    8f77cfa View commit details
    Browse the repository at this point in the history

  3. Revert "GranularPitchShifterEffect should not call checkGate" 

    This reverts commit 67526f0.
    @messmerd
    messmerd committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f552f7c View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. VstEffect: Simplify setting "Don't Run" state

    @messmerd
    messmerd committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    df58a76 View commit details
    Browse the repository at this point in the history

  2. Rename sleepImpl to processBypassedImpl

    @messmerd
    messmerd committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a262d17 View commit details
    Browse the repository at this point in the history

  3. Use MAXIMUM_BUFFER_SIZE in SetupDialog

    @messmerd
    messmerd committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0f070e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Pass outSum as out parameter; Fix LadspaEffect mutex

    @messmerd
    messmerd committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6efad9b View commit details
    Browse the repository at this point in the history

  2. Move outSum calculations to wrapper method

    @messmerd
    messmerd committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    826b193 View commit details
    Browse the repository at this point in the history

  3. Fix Linux build

    @messmerd
    messmerd committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5dee396 View commit details
    Browse the repository at this point in the history

  4. Oops

    @messmerd
    messmerd committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ef53c0f View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Johannes Lorenz <[email protected]>
    @messmerd @JohannesLorenz
    messmerd and JohannesLorenz committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5523488 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Apply suggestions from code review 

    Co-authored-by: saker <[email protected]>
    @messmerd @sakertooth
    messmerd and sakertooth committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6f3ec8c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/messmerd/lmms into effect… 

    …-process-wrapper
    @messmerd
    messmerd committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a165c27 View commit details
    Browse the repository at this point in the history