Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/#45] 타이머 알람여부 수정 API #46

Merged
merged 1 commit into from
Jan 11, 2024
Merged

[Feature/#45] 타이머 알람여부 수정 API #46

merged 1 commit into from
Jan 11, 2024

Conversation

mmihye
Copy link
Member

@mmihye mmihye commented Jan 10, 2024

🚩 관련 이슈

📋 구현 기능 명세

  • 타이머 알람여부 수정 API

📌 PR Point

  • 무슨 이유로 어떻게 코드를 변경했는지

  • 어떤 부분에 리뷰어가 집중해야 하는지

  • 개발하면서 어떤 점이 궁금했는지

📸 결과물 스크린샷

스크린샷 2024-01-11 오전 3 18 42

🛠️ 테스트

  • 테스트

🚀 API Endpoint

  • baseurl/timer/alarm/{timerId}

@mmihye mmihye requested a review from sss4920 January 10, 2024 18:18
@mmihye mmihye self-assigned this Jan 10, 2024
@mmihye mmihye changed the base branch from develop to test January 11, 2024 14:58
sss4920
sss4920 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@sss4920 sss4920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿! build.gradle도 바꿨네요!

@sss4920 sss4920 merged commit 16c31d0 into test Jan 11, 2024
1 check passed
@sss4920 sss4920 deleted the feature/#45 branch January 11, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sss4920 sss4920 sss4920 approved these changes

Assignees

@mmihye mmihye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] 타이머 알람 여부 수정
2 participants
@mmihye @sss4920