Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch dashboard pages #288

Merged
merged 12 commits into from
Jul 5, 2023
Merged

Conversation

SiongSng
Copy link
Member

@SiongSng SiongSng commented Jun 12, 2023

Description

Switch pages on the dashboard.
I create a new Vue component that named PageDashboard to manage pages (overview/class/lesson/note/exam), and test the effect of switch pages (click the button on the navigation bar)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 18978de
Status: ✅  Deploy successful!
Preview URL: https://0c1e724f.lipoic-frontend.pages.dev
Branch Preview URL: https://feature-switch-dashboard-pag.lipoic-frontend.pages.dev

View logs

src/pages/dashboard/PageClass.vue Show resolved Hide resolved
src/pages/dashboard/PageExam.vue Show resolved Hide resolved
src/pages/dashboard/PageLesson.vue Show resolved Hide resolved
src/pages/dashboard/PageNote.vue Show resolved Hide resolved
src/scss/global.scss Outdated Show resolved Hide resolved
@SiongSng SiongSng marked this pull request as ready for review June 27, 2023 14:37
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 30.13% and project coverage change: +11.18 🎉

Comparison is base (36302d3) 23.64% compared to head (18978de) 34.83%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #288       +/-   ##
============================================
+ Coverage    23.64%   34.83%   +11.18%     
============================================
  Files           41       47        +6     
  Lines         3083     3264      +181     
  Branches        46       51        +5     
============================================
+ Hits           729     1137      +408     
+ Misses        2354     2127      -227     
Impacted Files Coverage Δ
src/components/desktop/AppBar.vue 85.36% <ø> (ø)
...c/components/desktop/dashboard/OverviewContent.vue 0.00% <0.00%> (ø)
src/components/desktop/dashboard/RecentCard.vue 100.00% <ø> (ø)
src/components/mobile/AppBar.vue 0.00% <0.00%> (ø)
...rc/components/mobile/dashboard/MobileDashboard.vue 0.00% <0.00%> (ø)
...rc/components/mobile/dashboard/OverviewContent.vue 0.00% <0.00%> (ø)
src/components/mobile/dashboard/RecentCard.vue 100.00% <ø> (ø)
src/pages/PageDashboard.vue 0.00% <0.00%> (ø)
src/pages/PageHome.vue 0.00% <0.00%> (ø)
src/pages/dashboard/PageClass.vue 0.00% <0.00%> (ø)
... and 9 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@banahaker banahaker enabled auto-merge July 5, 2023 01:01
@banahaker banahaker merged commit f1d1d7f into develop Jul 5, 2023
6 checks passed
@banahaker banahaker deleted the feature/switch-dashboard-page branch July 5, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants