Fixed an issue where time to time the unicast and multicast ping-slot…

… windows could stop being opened up until the next beacon reception
Lora-net · Sep 25, 2023 · 0dc4903 · 0dc4903 · sborshch · Dec 11, 2023
1 parent d08d0d5
commit 0dc4903
Showing 1 changed file with 26 additions and 10 deletions.
diff --git a/src/mac/LoRaMacClassB.c b/src/mac/LoRaMacClassB.c
@@ -1023,11 +1023,19 @@ static void LoRaMacClassBProcessPingSlot( void )
                         pingSlotTime += pingSlotRxConfig.WindowOffset;
                     }
                 }
-
-                // Start the timer if the ping slot time is in range
-                LoRaMacClassBSetPingSlotState( PINGSLOT_STATE_IDLE );
-                TimerSetValue( &Ctx.PingSlotTimer, pingSlotTime );
-                TimerStart( &Ctx.PingSlotTimer );
+                if( pingSlotTime < CLASSB_BEACON_INTERVAL )
+                {
+                    // Start the timer if the ping slot time is in range
+                    LoRaMacClassBSetPingSlotState( PINGSLOT_STATE_IDLE );
+                    TimerSetValue( &Ctx.PingSlotTimer, pingSlotTime );
+                    TimerStart( &Ctx.PingSlotTimer );
+                }
+                else
+                {
+                    LoRaMacClassBSetMulticastSlotState( PINGSLOT_STATE_CALC_PING_OFFSET );
+                    TimerSetValue( &Ctx.PingSlotTimer, 1 );
+                    TimerStart( &Ctx.PingSlotTimer );
+                }
             }
             break;
         }
@@ -1196,11 +1204,19 @@ static void LoRaMacClassBProcessMulticastSlot( void )
                 {// Apply the window offset
                     multicastSlotTime += multicastSlotRxConfig.WindowOffset;
                 }
-
-                // Start the timer if the ping slot time is in range
-                LoRaMacClassBSetMulticastSlotState( PINGSLOT_STATE_IDLE );
-                TimerSetValue( &Ctx.MulticastSlotTimer, multicastSlotTime );
-                TimerStart( &Ctx.MulticastSlotTimer );
+                if( multicastSlotTime < CLASSB_BEACON_INTERVAL )
+                {
+                    // Start the timer if the ping slot time is in range
+                    LoRaMacClassBSetMulticastSlotState( PINGSLOT_STATE_IDLE );
+                    TimerSetValue( &Ctx.MulticastSlotTimer, multicastSlotTime );
+                    TimerStart( &Ctx.MulticastSlotTimer );
+                }
+                else
+                {
+                    LoRaMacClassBSetMulticastSlotState( PINGSLOT_STATE_CALC_PING_OFFSET );
+                    TimerSetValue( &Ctx.MulticastSlotTimer, 1 );
+                    TimerStart( &Ctx.MulticastSlotTimer );
+                }
             }
             break;
         }