Power of Two cached arrays only #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e are various questions that remain, including whether the game will work with this. Feeding the arrays given to compress into the cache, however, constitutes a memory leak; and if anyone who called compress reuses this array, this causes undefined corruption.
thygrrr
commented
Oct 5, 2018
| @@ -35,32 +36,10 @@ public void CompressData_NoIssues() | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void CompressDataReuseArrays() | |||
There was a problem hiding this comment.
I tried to write a adapted version of this test, but it wouldn't work.
|
I don't think this should be merged. :( 👎 At least not before I find out why compress suddenly needs memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed ArrayPool so it will only work with Power of Two arrays. There are various questions that remain, including whether the mod as it is will work with this. Feeding the arrays given to compress into the cache, however, constitutes a memory leak; and if anyone who called compress reuses this array, this causes undefined corruption.
Fixes:
Last question: