Update the dockerfile to fix APCEMM run issue #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #47 describes APCEMM hanging when attempting to run the provided example in the docker instance.
@dcdrake pointed out that the
vcpkg
installation was installing other versions of dependencies than those in the dockerfile, as well as the fact that the wrong version ofgcc
was being used by the dockerfile. This appears to have been the cause of the above issue.This PR fixes the above as follows:
gcc
has been updated to 11.2 in the dockerfilevcpkg
have been removed from the dockerfileThe following nice-to-haves have also been done:
cmake
in the dockerfile to 3.30.3 to avoid the need to download a portable cmake version when compiling APCEMM.Thanks a lot @dcdrake!